Remove unsafe code from WinHttpHandler TryGetHeaderName helper#114484
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Apr 10, 2025
Merged
Remove unsafe code from WinHttpHandler TryGetHeaderName helper#114484MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/libraries/System.Net.Http/src/System.Net.Http.csproj: Language not supported
- src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj: Language not supported
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
approved these changes
Apr 10, 2025
ManickaP
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The byte-based overload is unused, which lets us delete a bunch of the (unsafe) helper code around it.
It should also be faster now since we don't have 100 delegate calls in that method anymore.
It's also only used from WinHttpHandler, so I removed the references from
System.Net.Http.csproj.