Skip to content

Never inline AllocateInstances in COM lifetime test #114648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkoritzinsky merged 1 commit into from
Apr 14, 2025
Merged

Never inline AllocateInstances in COM lifetime test #114648

jkoritzinsky merged 1 commit into from
Apr 14, 2025

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Apr 14, 2025

Fixes #112334

JITStress_Random was picking JITStress values that forced at least one call of AllocateInstances to be inlined.

Never allow it to be inlined to avoid having lifetime extension issues that cause failures (and later asserts).

Copilot AI review requested due to automatic review settings April 14, 2025 18:59
@ghost ghost added the area-Interop-coreclr label Apr 14, 2025
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@jkoritzinsky jkoritzinsky added the test-bug Problem in test source code (most likely) label Apr 14, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 14, 2025

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jkoritzinsky jkoritzinsky merged commit ed3081f into dotnet:main Apr 14, 2025
75 of 77 checks passed
@jkoritzinsky jkoritzinsky deleted the lifetime-outline branch April 14, 2025 22:00
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels

area-Interop-coreclr test-bug Problem in test source code (most likely)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: Interop/COM/NETClients/Lifetime/NETClientLifetime/NETClientLifetime.cmd

2 participants

@jkoritzinsky @AaronRobinsonMSFT