Skip to content

[release/10.0-preview4] [Test Only] Fix Idn failing tests #115021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 2 commits into from
Apr 25, 2025
Merged

[release/10.0-preview4] [Test Only] Fix Idn failing tests #115021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6107fb
Fix Idn failing tests
tarekgh Apr 24, 2025
aabdb6b
Minor fix
tarekgh Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ies/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ private static Stream GetIdnaTestTxt()
string fileName = null;
if (PlatformDetection.ICUVersion >= new Version(76, 0))
fileName = "IdnaTest_16.txt";
else if (PlatformDetection.ICUVersion >= new Version(74, 0))
else if (PlatformDetection.ICUVersion >= new Version(72, 0))
fileName = "IdnaTest_15_1.txt";
else if (PlatformDetection.ICUVersion >= new Version(66, 0) || PlatformDetection.IsHybridGlobalizationOnApplePlatform)
fileName = "IdnaTest_13.txt";
Expand Down Expand Up @@ -67,7 +67,7 @@ private static IConformanceIdnaTest GetConformanceIdnaTest(string line, int line
{
if (PlatformDetection.ICUVersion >= new Version(76, 0))
return new Unicode_16_0_IdnaTest(line, lineCount);
else if (PlatformDetection.ICUVersion >= new Version(74, 0))
else if (PlatformDetection.ICUVersion >= new Version(72, 0))
return new Unicode_15_1_IdnaTest(line, lineCount);
else if (PlatformDetection.ICUVersion >= new Version(66, 0) || PlatformDetection.IsHybridGlobalizationOnApplePlatform)
return new Unicode_13_0_IdnaTest(line, lineCount);
Expand Down
Loading