Skip to content

Conversation

@richlander
Copy link
Member

Copilot AI review requested due to automatic review settings April 26, 2025 01:55
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for Raspbian 10 from various parts of the codebase as part of deprecating this platform.

  • Removed the IsRaspbian10 property and its related test ActiveIssue from MsQuicPlatformDetectionTests.cs and PlatformDetection.Unix.cs.
  • Eliminated pipeline configurations and documentation related to linux_armv6 and Raspbian 10.

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs Removed ActiveIssue referencing IsRaspbian10 from tests.
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs Deleted the IsRaspbian10 property.
eng/pipelines/runtime-community.yml Removed commented armv6 build steps related to Raspbian 10.
eng/pipelines/libraries/helix-queues-setup.yml Removed Linux armv6 configuration referencing Raspbian 10.
eng/pipelines/common/templates/pipeline-with-resources.yml Removed linux_armv6 environment configuration.
eng/pipelines/common/platform-matrix.yml Removed Linux armv6 matrix templates.
docs/workflow/building/coreclr/linux-instructions.md Removed documentation entry for Ubuntu 20.04 (armv6/Raspbian 10).
Files not reviewed (2)
  • Directory.Build.props: Language not supported
  • eng/Subsets.props: Language not supported

}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsRaspbian10), nameof(PlatformDetection.IsArmv6Process), nameof(PlatformDetection.IsInContainer))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsArmv6Process can be deleted too

@jkotas
Copy link
Member

jkotas commented Apr 26, 2025

https://github.com/dotnet/runtime/tree/release/9.0-staging

Should this go to main branch first? We typically checkin to main first and then backport as necessary.

@jkotas jkotas added runtime-mono specific to the Mono runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 26, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@richlander
Copy link
Member Author

Fair. I'll do that.

@richlander richlander closed this Apr 28, 2025
@richlander richlander mentioned this pull request Apr 28, 2025
@richlander richlander deleted the 9.0-staging-raspbian branch April 28, 2025 20:56
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure runtime-mono specific to the Mono runtime

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants