Skip to content

[WinHTTP] Fix certificate caching timeout #115144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liveans merged 2 commits into from
Apr 30, 2025
Merged

[WinHTTP] Fix certificate caching timeout #115144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f8ec42
Fix timeout
liveans Apr 29, 2025
9700a20
Merge branch 'main' into fix_timeout_comparison
liveans Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class WinHttpHandler : HttpMessageHandler

private static readonly Lazy<bool> s_supportsTls13 = new Lazy<bool>(CheckTls13Support);
private static readonly TimeSpan s_cleanCachedCertificateTimeout = TimeSpan.FromMilliseconds((int?)AppDomain.CurrentDomain.GetData("System.Net.Http.WinHttpCertificateCachingCleanupTimerInterval") ?? 60_000);
private static readonly long s_staleTimeout = (long)(s_cleanCachedCertificateTimeout.TotalSeconds * Stopwatch.Frequency / 1000);
private static readonly long s_staleTimeout = (long)(s_cleanCachedCertificateTimeout.TotalSeconds * Stopwatch.Frequency);

[ThreadStatic]
private static StringBuilder? t_requestHeadersBuilder;
Expand Down
Loading