Skip to content

Fix globalization test on mobile platforms #115248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 4 commits into from
May 2, 2025
Merged

Fix globalization test on mobile platforms #115248

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e573fa7
Fix globalization test on mobile platforms
tarekgh May 2, 2025
d593d99
Update src/libraries/System.Runtime/tests/System.Globalization.Tests/…
tarekgh May 2, 2025
17eb45e
minor update
tarekgh May 2, 2025
63365e6
fix comment
tarekgh May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/libraries/System.Runtime/tests/System.Globalization.Tests/CultureInfo/CultureInfoCtor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,11 +388,28 @@ public static IEnumerable<object[]> Ctor_String_TestData()
}
}

public static IEnumerable<object[]> Ctor_Undetermined_TestData()
{
yield return new object[] { "und-us", "und-US", "und-US" };
yield return new object[] { "und-us_tradnl", "und-US", "und-US_tradnl"};

// On AppleMobile, the behavior of CultureInfo differs due to platform-specific
// handling of Unicode extensions and subtags. These platforms preserve the full language tag, including
// extensions, while other platforms normalize the tag to a simpler form.
if (PlatformDetection.IsAppleMobile)
{
yield return new object[] { "und-es-u-co-phoneb", "und-ES-u-co-phoneb", "und-ES-u-co-phoneb" };
yield return new object[] { "und-es-t-something", "und-ES-t-something", "und-ES-t-something" };
}
else
{
yield return new object[] { "und-es-u-co-phoneb", "und-ES", "und-ES_phoneb" };
yield return new object[] { "und-es-t-something", "und-ES", "und-ES"};
}
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsIcuGlobalization))]
[InlineData("und-us", "und-US", "und-US")]
[InlineData("und-us_tradnl", "und-US", "und-US_tradnl")]
[InlineData("und-es-u-co-phoneb", "und-ES", "und-ES_phoneb")]
[InlineData("und-es-t-something", "und-ES", "und-ES")]
[MemberData(nameof(Ctor_Undetermined_TestData))]
public void CtorUndeterminedLanguageTag(string cultureName, string expectedCultureName, string expectedSortName)
{
CultureInfo culture = new CultureInfo(cultureName);
Expand Down
Loading