Skip to content

Dump more info in JitDump for HWIHNTRINSIC nodes #115255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BruceForstall merged 1 commit into from
May 3, 2025
Merged

Dump more info in JitDump for HWIHNTRINSIC nodes #115255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13038,14 +13038,18 @@ void Compiler::gtDispTree(GenTree* tree,

#if defined(FEATURE_HW_INTRINSICS)
case GT_HWINTRINSIC:
if (tree->OperIs(GT_HWINTRINSIC))
{
GenTreeHWIntrinsic* node = tree->AsHWIntrinsic();
printf(" %u", node->GetSimdSize());
Copy link

Copilot AI May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider combining the multiple printf calls into a single call to improve code readability and reduce potential overhead.

Copilot uses AI. Check for mistakes.
if (node->GetSimdBaseType() != TYP_UNKNOWN)
{
printf(" %s", varTypeName(node->GetSimdBaseType()));
}
if (node->GetAuxiliaryType() != TYP_UNKNOWN)
{
printf(" %s %s",
tree->AsHWIntrinsic()->GetSimdBaseType() == TYP_UNKNOWN
? ""
: varTypeName(tree->AsHWIntrinsic()->GetSimdBaseType()),
HWIntrinsicInfo::lookupName(tree->AsHWIntrinsic()->GetHWIntrinsicId()));
printf(" (aux %s)", varTypeName(node->GetAuxiliaryType()));
Copy link

Copilot AI May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Ensure that the format of printing the auxiliary type (with parentheses) is consistent with other debug outputs; consider adding a comment to clarify the intended formatting.

Suggested change
printf(" (aux %s)", varTypeName(node->GetAuxiliaryType()));
// Print the auxiliary type without parentheses for consistency with other debug outputs.
printf(" aux %s", varTypeName(node->GetAuxiliaryType()));

Copilot uses AI. Check for mistakes.
}
printf(" %s", HWIntrinsicInfo::lookupName(node->GetHWIntrinsicId()));

gtDispCommonEndLine(tree);

Expand All @@ -13058,7 +13062,8 @@ void Compiler::gtDispTree(GenTree* tree,
gtDispChild(operand, indentStack, ++index < count ? IIArc : IIArcBottom, nullptr, topOnly);
}
}
break;
}
break;
#endif // defined(FEATURE_HW_INTRINSICS)

case GT_ARR_ELEM:
Expand Down
Loading