System.Runtime.Serialization.Xml: throw SerializationException on malformed prefix#118571
Open
imcarolwang wants to merge 3 commits intodotnet:mainfrom
Open
System.Runtime.Serialization.Xml: throw SerializationException on malformed prefix#118571imcarolwang wants to merge 3 commits intodotnet:mainfrom
imcarolwang wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the XML serialization library by ensuring that malformed XML with invalid prefixes throws the expected SerializationException rather than leaking an ArgumentException. The fix addresses cases where malformed prefixed elements (like <s:) cause the XML parser to encounter empty local names.
- Wraps
ArgumentExceptionwithSerializationExceptionto maintain consistent error handling contract - Adds exception handling in two methods:
InternalIsStartObjectandIsStartObjectHandleExceptions - Includes regression test to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| XmlObjectSerializer.cs | Adds exception handling to wrap ArgumentException in SerializationException for two XML parsing methods |
| DataContractSerializer.cs | Adds regression test with malformed XML input and helper test types |
Comments suppressed due to low confidence (1)
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an unfinished prefixed element ("<s:"), ReadObject previously surfaced ArgumentException (param "name"). Now it wraps the error in SerializationException per serializer contract.
Add regression test:
Fixes #1409.