Reenable tests for interpreter #121978
Merged
Reenable tests for interpreter #121978
+0
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reenables tests that were formerly causing crashes or hangs of whole coreclr test suites and now work fine.
kg
approved these changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables 39 test files that were previously disabled for the CoreCLR interpreter due to crashes or hangs (issue #120904). The tests now work correctly and can be run without issues. The changes involve removing [ActiveIssue] attributes from test entry points across threading generics tests and JIT-related tests.
Key Changes
- Removed
[ActiveIssue]attributes from 30 WaitCallback threading generic tests (thread01-thread30) - Removed
[ActiveIssue]attributes from 9 JIT tests (SIMD tests, regression tests, and conversion tests)
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 30 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/baseservices/threading/generics/WaitCallback/thread01.cs - thread30.cs | Removed ActiveIssue attributes to re-enable threading pool tests with generic type parameters |
| src/tests/JIT/jit64/opt/rngchk/RngchkStress3.cs | Re-enabled range check optimization stress test |
| src/tests/JIT/SIMD/Sums.cs | Re-enabled SIMD vector math test |
| src/tests/JIT/Regression/JitBlue/GitHub_19438/GitHub_19438.cs | Re-enabled Vector4 performance regression test |
| src/tests/JIT/Regression/CLR-x86-JIT/v2.1/b609988/b609988.il | Removed ActiveIssue attribute from IL test |
| src/tests/JIT/Regression/CLR-x86-JIT/v2.1/b609988/Desktop/b609988_Desktop.il | Removed ActiveIssue attribute from Desktop variant IL test |
| src/tests/JIT/Performance/CodeQuality/SIMD/ConsoleMandel/ConsoleMandel.cs | Re-enabled SIMD Mandelbrot performance test |
| src/tests/JIT/Directed/Convert/out_of_range_fp_to_int_conversions.cs | Re-enabled floating-point to integer conversion edge case test |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/tests/baseservices/threading/generics/WaitCallback/thread20.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread13.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread11.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread10.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread02.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread28.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread22.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread16.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread14.cs
Outdated
Show resolved
Hide resolved
src/tests/baseservices/threading/generics/WaitCallback/thread03.cs
Outdated
Show resolved
Hide resolved
Change spaces to tabs to match the rest of the test source files. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Actually, the test run results were hiding some suites that were still crashing. I need to investigate and re-enable some of these. |
Member
Author
|
Ok, they were not crashing, just one of the tests was taking more time to complete. As that is machine specific, I am going to get this PR as-is |
Member
Author
|
Actually, still re-disabling the JIT/jit64/opt/rngchk/RngchkStress3 as it takes really a lot of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reenables tests that were formerly causing crashes or hangs of whole coreclr test suites and now work fine.