[browser] Add DiagnosticPorts to DOTNET_DiagnosticPorts environment variable #122019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
requested review from
akoeplinger,
lewing and
pavelsavara
as code owners
maraf
added
arch-wasm
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes the DiagnosticPorts implementation from WasmAppBuilder to the WasmSDK level by adding support for the DiagnosticPorts MSBuild property to be automatically set as the DOTNET_DiagnosticPorts environment variable in browser WASM applications.
- Adds
DiagnosticPortsto the list of nested build properties in sample WASM builds - Creates a new MSBuild target
_AddWasmDiagnosticPortsEnvironmentVariablethat populatesWasmEnvironmentVariablewith the diagnostic ports configuration - Integrates this target into both build and publish workflows
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/sample/wasm/Directory.Build.targets | Adds DiagnosticPorts to the NestedBuildProperty item group to enable passing this property through nested builds |
| src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets | Implements _AddWasmDiagnosticPortsEnvironmentVariable target and adds it as a dependency to both GenerateBuildWasmBootJsonDependsOn and GeneratePublishWasmBootJsonDependsOn to ensure diagnostic ports are configured in both build and publish scenarios |
pavelsavara
approved these changes
Nov 27, 2025
Member
Author
|
/ba-g Timeout is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this implemention in WasmAppBuilder. This PR promotes it to WasmSDK