Avoid temporary List allocation with HTTP/3 trailers #122677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes HTTP/3 trailing header processing by eliminating an intermediate List<(HeaderDescriptor, string)> allocation. Instead, trailing headers are written directly into an HttpResponseHeaders instance, matching the pattern already used in HTTP/2.
Key changes:
- Changed
_trailingHeadersfield type fromList<(HeaderDescriptor, string)>?toHttpResponseHeaders? - Simplified
CopyTrailersToResponseMessageto useStoreReceivedTrailingHeadersAPI - Updated header addition logic to call
TryAddWithoutValidationdirectly on the headers collection
This was referenced Jan 5, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can write directly into the final header collection, no need for the List in between.
We already do the same with HTTP/2.