Implement label validation and typedef resolution in C# ilasm#123002
Merged
jkoritzinsky merged 8 commits intodotnet:mainfrom Jan 28, 2026
Merged
Implement label validation and typedef resolution in C# ilasm#123002jkoritzinsky merged 8 commits intodotnet:mainfrom
jkoritzinsky merged 8 commits intodotnet:mainfrom
Conversation
- Consolidate instruction tokens into main grammar to establish proper lexer precedence over DOTTEDNAME and ID; reorder methodDecl alternatives to match instructions first; add custom attribute handling in method bodies - Implement visitor stubs for debug/symbol directives: VisitLanguageDecl, VisitEsHead, VisitExportHead, VisitExtSourceSpec, VisitFieldInit - Add typedef resolution in ResolveTypeDef for type aliases - Implement label validation: track declared vs referenced labels, report errors for undefined labels at method end - Allow recoverable errors in method bodies to still emit assembly - Add tests for label validation, typedef resolution, and error handling
github-actions
Bot
added
the
needs-area-label
dotnet-policy-service
Bot
added
the
community-contribution
am11
added
area-ILTools-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT |
jkoritzinsky
reviewed
Jan 8, 2026
Member
|
Can we gather test coverage for ilasm/this change? Test coverage for ilasm should be pretty easy to measure and ideally we would never regress coverage percent. |
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Looking much better! Just a few more comments.
Also, if you can get the code-coverage info that @agocke mentioned, I think that would be a great idea
Member
Author
|
Coverage baseline is not too impressive, but it is what it is rn 😅 |
jkoritzinsky
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate instruction tokens into main grammar to establish proper lexer precedence over DOTTEDNAME and ID; reorder methodDecl alternatives to match instructions first; add custom attribute handling in method bodies
Implement visitor stubs for debug/symbol directives: VisitLanguageDecl, VisitEsHead, VisitExportHead, VisitExtSourceSpec, VisitFieldInit
Add typedef resolution in ResolveTypeDef for type aliases
Implement label validation: track declared vs referenced labels, report errors for undefined labels at method end
Allow recoverable errors in method bodies to still emit assembly
Add tests for label validation, typedef resolution, and error handling