Add binary VN funcs to TryGetRangeFromAssertions #123233
Merged
+199
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
This was referenced Jan 16, 2026
EgorBo
commented
Jan 20, 2026
jakobbotsch
reviewed
Jan 20, 2026
EgorBo
force-pushed
the
refactor-range-ops
branch
from
df7af53 to
7117893
Compare
EgorBo
force-pushed
the
refactor-range-ops
branch
from
74bbb1c to
c468b04
Compare
Member
Author
|
@jakobbotsch PTAL again, I still have a few ideas for a refactoring, but those should be zero diffs and will be in a separate PR. Now I am slowly moving towards repeating what SSA-based GetRange does, but only with VNs Some 50-100k improvements are expected - diffs - although, there are regressions from previously semi-legal transformations based on half-defined ranges (e.g. [10..unknown]) PS: I think I also spot a few potential bugs when we could perform a multiplication on top of keBinOpArray or add two keBinOpArrays PS2: I recommend disabling the whitespaces on the review view. |
EgorBo
changed the title
3 tasks
Member
Author
|
ping @jakobbotsch |
jakobbotsch
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diffs
Fixes #122288
Also, enables more branch foldings based on assertions - basically, mimics what SSA-based GetRange does, but based only on VNs.
I recommend reviewing with whitespaces disabled.