Skip to content

Conversation

@VSadov
Copy link
Member

@VSadov VSadov commented Jan 20, 2026

Fixes: #122672

These are reflection-like internal APIs to query for methods by name and other traits.
For the same reasons as with reflection, the callers would not expect to see async variants.

If async variants ever need to be considered by these APIs, they have flags (FM_Flags, DelegateBindingFlags, ...) where such desire could be expressed.

Copilot AI review requested due to automatic review settings January 20, 2026 22:57
@VSadov VSadov requested review from jkotas and removed request for Copilot January 20, 2026 22:58
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member Author

VSadov commented Jan 20, 2026

CC: @pavelsavara

@jkotas
Copy link
Member

jkotas commented Jan 20, 2026

Can you also delete wasm opt-out from runtimeasync in src\coreclr\inc\clrconfigvalues.h

@jkotas
Copy link
Member

jkotas commented Jan 20, 2026

LGTM otherwise

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@jkotas
Copy link
Member

jkotas commented Jan 21, 2026

@pavelsavara This PR is changing CoreCLR wasm, but it does not appear to be triggering any CoreCLR wasm testing. Am I missing something?

@pavelsavara
Copy link
Member

I added the trigger

WBT is passing on it 🎉

Launching chrome ('/root/helix/work/correlation/chrome-linux/chrome') via playwright with args = --explicitly-allowed-ports=34241,--ignore-certificate-errors,--lang=en-US,--headless
Waiting for page to load
Waiting for additional 10secs to see if any errors are reported
[log] TestOutput -> Hello from WasmBrowserRunMainOnly!
Exited with 0
[log] WASM EXIT 0

The libraries tests were fixed by #123423
I will merge main to make sure this is good

@VSadov VSadov enabled auto-merge (squash) January 21, 2026 22:41
@VSadov VSadov merged commit 0de4dab into dotnet:main Jan 22, 2026
130 checks passed
@VSadov VSadov deleted the asyncFindMethod branch January 22, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip async variants in MemberLoader::FindMethod (blocking wasm)

3 participants