-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[RuntimeAsync] FindMethod, FindMethodByName, Delegate_BindToMethodName should skip async variants. #123409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @mangod9 |
|
CC: @pavelsavara |
|
Can you also delete wasm opt-out from runtimeasync in src\coreclr\inc\clrconfigvalues.h |
|
LGTM otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
|
@pavelsavara This PR is changing CoreCLR wasm, but it does not appear to be triggering any CoreCLR wasm testing. Am I missing something? |
|
I added the trigger WBT is passing on it 🎉 The libraries tests were fixed by #123423 |
Fixes: #122672
These are reflection-like internal APIs to query for methods by name and other traits.
For the same reasons as with reflection, the callers would not expect to see async variants.
If async variants ever need to be considered by these APIs, they have flags (
FM_Flags,DelegateBindingFlags, ...) where such desire could be expressed.