Avoid incorrectly resolving a MonoClass for MONO_TYPE_GENERICINST when loading custom attribute values. #123439
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid incorrectly resolving a MonoClass for
MONO_TYPE_GENERICINSTwhen loading custom attribute values.load_cattr_value()previously unconditionally calledm_type_data_get_klass(), which is invalid forGENERICINSTand could lead to incorrect behavior when processing generic enum instances. This change defers class resolution forMONO_TYPE_GENERICINSTand handles enum generic instances explicitly by extracting the underlying element type. This fixes a crash when decoding custom attributes involving generic types.This crashes in Mono but doesn't in CoreClr
Output on CoreClr:
Output on Mono without fix:
Output on Mono with fix: