[browser] Add publish-time telemetry for WebAssembly configuration properties#123534
[browser] Add publish-time telemetry for WebAssembly configuration properties#123534
Conversation
…rties Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
@copilot Include |
Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
…sibility point - Add public WorkloadTelemetryDependsOn property to WorkloadTelemetry.targets so downstream targets can hook into the telemetry pipeline - Replace standalone _WasmPublishTelemetry target and WasmPublishConfig event with _GatherWasmPublishTelemetry that appends to WorkloadPublishProperties - No new telemetry event name needed; reuses existing allow-listed event Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
@copilot Add a comment that this needs to be synchronized with docs at https://github.com/dotnet/sdk/blob/main/documentation/project-docs/telemetry.md
There was a problem hiding this comment.
Added comment linking to SDK telemetry documentation in commit e8dd483.
Co-authored-by: maraf <10020471+maraf@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/07037637-7fa4-4927-ae4c-1315e37aee1d
Code Review: Add publish-time telemetry for WebAssembly/Blazor config propertiesVerdict: LGTM 👍 SummaryThis PR adds WASM-specific publish telemetry by:
AnalysisArchitecture & Design ✅ Correctness ✅
Property evaluation ordering ✅
No issues found. The change is minimal, well-targeted, and follows established patterns in the telemetry infrastructure.
|
Description
Adds telemetry to capture effective values of key WASM/Blazor publish configuration properties (globalization mode, boot config shape, fingerprinting, preload behavior, bundler friendliness, runtime selection) to inform defaults and compatibility decisions.
Changes
Added
_GatherWasmPublishTelemetrytarget inMicrosoft.NET.Sdk.WebAssembly.Browser.targetsWorkloadTelemetryDependsOnextensibility pointCondition="'$(WasmBuildingForNestedPublish)' != 'true'"WorkloadPublishPropertiestelemetry eventCaptures 10 properties using normalized internal values where applicable:
InvariantTimezone(derived fromBlazorEnableTimeZoneSupport)InvariantGlobalization(_WasmInvariantGlobalization)BlazorWebAssemblyLoadAllGlobalizationData(_BlazorWebAssemblyLoadAllGlobalizationData)WasmEnableWebcil(_WasmEnableWebcil)WasmInlineBootConfig(_WasmInlineBootConfig)OverrideHtmlAssetPlaceholders(raw value)WasmFingerprintBootConfig(_WasmFingerprintBootConfig)WasmPreloadAssets(_WasmPreloadAssets)WasmBundlerFriendlyBootConfig(_WasmBundlerFriendlyBootConfig)UseMonoRuntime(raw value)Notes
Integrates with the existing
WorkloadPublishPropertiestelemetry event. Properties collected here need to be synchronized with SDK telemetry documentation at https://github.com/dotnet/sdk/blob/main/documentation/project-docs/telemetry.md.No PII—only boolean configuration flags.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.