[release/10.0] Fix internal validation pipeline #123825
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
This PR fixes internal validation pipeline issues for .NET 10.0 by addressing incorrect helix queue usage and authentication problems for internal builds.
Changes:
- Replaced manual NuGet source authentication setup with centralized
enable-internal-sources.ymltemplate across multiple pipeline files - Added public/internal build distinctions for helix queue selection to ensure internal builds use appropriate queues
- Added
templatePathparameter support to enable different template paths for public vs. internal/official builds
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/libraries/run-test-job.yml | Added templatePath parameter; replaced manual NuGet credential setup with enable-internal-sources.yml template |
| eng/pipelines/libraries/helix-queues-setup.yml | Modified Android queue selection to use Ubuntu-based queue for all internal builds since Windows.11.Amd64.Android queue has no internal equivalent |
| eng/pipelines/diagnostics/runtime-diag-job.yml | Replaced manual NuGet credential setup with enable-internal-sources.yml template |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Added public/internal conditional logic for helix queues (iOS, Android, Browser WASM, tvOS platforms) |
| eng/pipelines/common/templates/runtimes/xplat-job.yml | Added enable-internal-sources.yml template call for authentication |
| eng/pipelines/common/global-build-job.yml | Replaced manual NuGet credential setup with enable-internal-sources.yml template |
| - ${{ if in(parameters.platform, 'tvos_arm64') }}: | ||
| - OSX.15.Amd64.AppleTV.Open | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - OSX.15.Amd64.AppleTV.Open |
There was a problem hiding this comment.
Inconsistent indentation on this line. The list item should be indented with 8 spaces to align with other queue entries in the file (see lines 73, 75, 82, etc.), but this line has 10 spaces.
| - OSX.15.Amd64.AppleTV.Open | |
| - OSX.15.Amd64.AppleTV.Open |
jkoritzinsky
changed the title
| # Always use the Ubuntu-based Android queue for internal validation as there is no internal equivalent of | ||
| # the Windows.11.Amd64.Android.Open queue. | ||
| - ${{ if or(eq(variables['System.TeamProject'], 'internal'), in(parameters.platform, 'android_x86', 'android_x64', 'linux_bionic_x64')) }}: | ||
| - Ubuntu.2204.Amd64.Android.29.Open |
There was a problem hiding this comment.
Why are we using open queues in internal?
There was a problem hiding this comment.
We strip the .Open name in the libraries infra, so I wanted to keep consistent (Open queues don't actually work from internal branches). Technically I think we can drop the .Open here.
2 participants
Fixes #123444
main PR #123452
Description
Fix internal validation pipeline so we can validate backflow from the VMR for internal/release/10.x.
Customer Impact
None, infra only change
Regression
None, infra only change
Testing
Risk
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.