Remove unused ToUpperInvariantMode methods #123852
Open
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused ToUpperInvariantMode
Remove unused ToUpperInvariantMode methods
Feb 1, 2026
stephentoub
approved these changes
Feb 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two unused methods from OrdinalCasing.Icu.cs: ToUpperInvariantMode(char c) and ToUpperInvariantMode(ReadOnlySpan<char> source, Span<char> destination). These methods have no callers in the codebase. The similar ToUpperOrdinal method is used instead throughout the runtime for ordinal case conversions.
Changes:
- Removed unused
internal static char ToUpperInvariantMode(char c)method - Removed unused
public static void ToUpperInvariantMode(ReadOnlySpan<char> source, Span<char> destination)extension method
MihaZupan
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ToUpperInvariantMode(both thecharandReadOnlySpan<char>overloads) inOrdinalCasing.Icu.cshave no callers anywhere in the codebase. The similarToUpperOrdinalmethod is used instead.Changes
internal static char ToUpperInvariantMode(char c)public static void ToUpperInvariantMode(this ReadOnlySpan<char> source, Span<char> destination)Verified via codebase-wide search that no code references these methods. Build passes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.