Skip to content

Update stack trace patterns to handle Android platform stack trace #124080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 2 commits into from
Feb 9, 2026
Merged

Update stack trace patterns to handle Android platform stack trace #124080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b028c6b
Update stack trace patterns to handle Android platform stack trace
kotlarmilos Feb 6, 2026
6ca69a8
Add tracking issue
kotlarmilos Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,37 +583,42 @@ public void ToString_ShowILOffset()
}, regPattern).Dispose();
}

// On Android, stack traces do not include file names and line numbers
Comment thread
kotlarmilos marked this conversation as resolved.
// Tracking issue: https://github.com/dotnet/runtime/issues/124087
private static string FileInfoPattern(string fileLinePattern) =>
PlatformDetection.IsAndroid ? "" : fileLinePattern;
Comment thread
jkotas marked this conversation as resolved.

public static Dictionary<string, string[]> MethodExceptionStrings = new()
{
{ "Foo", new[] {
@"Exception from Foo2",
@"V2Methods\.Foo2\(Int32.*Foo2.*\.cs:line 10",
@"V2Methods\.Foo1\(Int32.*Foo1.*\.cs:line 6",
@"V2Methods\.Foo2\(Int32" + FileInfoPattern(@".*Foo2.*\.cs:line 10"),
@"V2Methods\.Foo1\(Int32" + FileInfoPattern(@".*Foo1.*\.cs:line 6"),
@"V1Methods.*Test1",
@"V1Methods.*Test0",
@"V2Methods\.Foo\(\).*Foo.*\.cs:line 6"
@"V2Methods\.Foo\(\)" + FileInfoPattern(@".*Foo.*\.cs:line 6")
}},
{ "Bar", new[] {
@"Exception from Bar",
@"V2Methods\.Bar\(Int32.*Bar.*\.cs:line 4",
@"V2Methods\.Bar\(Int32.*Bar.*\.cs:line 5"
@"V2Methods\.Bar\(Int32" + FileInfoPattern(@".*Bar.*\.cs:line 4"),
@"V2Methods\.Bar\(Int32" + FileInfoPattern(@".*Bar.*\.cs:line 5")
}},
{"Quux", new[] {
@"Exception from Quux1",
@"V2Methods\.Quux1\(Int32.*Quux1.*\.cs:line 6",
@"V2Methods\.Quux1\(Int32" + FileInfoPattern(@".*Quux1.*\.cs:line 6"),
@"V1Methods.*Test1",
@"V1Methods.*Test0",
@"V2Methods\.Quux\(\).*Quux.*\.cs:line 6"
@"V2Methods\.Quux\(\)" + FileInfoPattern(@".*Quux.*\.cs:line 6")
}},
{ "Quuux", new[] {
@"Exception from Quuux2",
@"V2Methods\.Quuux2\(\).*Quuux2.*\.cs:line 4",
@"V2Methods\.Quuux\(\).*Quuux.*\.cs:line [35]" // if yield finishes before Task is awaited, line 3 else line 5. Either is ok.
@"V2Methods\.Quuux2\(\)" + FileInfoPattern(@".*Quuux2.*\.cs:line 4"),
@"V2Methods\.Quuux\(\)" + FileInfoPattern(@".*Quuux.*\.cs:line [35]") // if yield finishes before Task is awaited, line 3 else line 5. Either is ok.
}},
{"Bux", new[] {
@"Exception from Baz method.",
@"V2Methods\.Baz\(\).*Baz.*\.cs:line 4",
@"V2Methods\.Bux\(\).*Bux.*\.cs:line 6"
@"V2Methods\.Baz\(\)" + FileInfoPattern(@".*Baz.*\.cs:line 4"),
@"V2Methods\.Bux\(\)" + FileInfoPattern(@".*Bux.*\.cs:line 6")
}},
};

Expand Down
Loading