[Wasm RyuJit] avoid reverse ops

[AndyAyersMS]

For Wasm we generally want operands evaluated in the normal order. So, suppress marking nodes with GT_REVERSE_OPS. On Wasm reversal is still possible for relops (where we can change the oper) and for commutative ops (where we can swap the operands).

We may want to enable reversal in other cases where there is a big imbalance in child tree complexity, but then we'll need to add changes to lower to spill the out of order tree to a temp to handle this.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts JIT tree evaluation-order heuristics for the WebAssembly target to prefer normal (non-reversed) operand evaluation order, avoiding use of GTF_REVERSE_OPS except where reversal can be expressed via operand swapping (commutative ops) or operator swapping (relops).

Changes:

• Disable reversal for indirect stores on WASM by forcing allowReversal = false in SetIndirectStoreEvalOrder.
• On WASM, suppress setting GTF_REVERSE_OPS in the “can’t commute” default swap path in both gtSetEvalOrder and gtSetEvalOrderMinOpts.

[AndyAyersMS]

fyi @dotnet/jit-contrib

Fixes some "IR not in stack order" asserts that we hit after lowering a reversed STOREIND.

The remaining instances of the "IR not in stack order" assert mostly seem to come from call lowering now, as best I can tell.

[SingleAccretion]

You can also consider adding a condition into OperSupportsReverseOpEvalOrder.

[AndyAyersMS]

You can also consider adding a condition into OperSupportsReverseOpEvalOrder.

Good idea.

[AndyAyersMS]

Various errors, all unrelated as this change is currently untestable in CI.

One looks like #123912. Another is infra...

ModuleNotFoundError: No module named 'pkg_resources'

[AndyAyersMS]

/ba-g unrelated errors

[AndyAyersMS]

/ba-g retry