Arm64 Sve: Fix double/float mask test issues #124224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Arm64 SVE mask-related test failures by treating float/double “mask lanes” as bit-patterns rather than numeric values, ensuring correct handling when masks are produced via reinterpret/bitcast semantics.
Changes:
- Default “all-true” masks for
double[]/float[]now use a non-zero bit-pattern viaBitConverter.*BitsTo*. - Mask checks in
AddSequentialAcrossnow evaluate mask lanes by checking their raw bits for non-zero. MaskBothSetnow checks for raw bit-pattern equality (== 1) instead of numeric equality (== 1.0).
Contributor
Author
|
@dotnet/arm64-contrib @dhartglassMSFT |
Contributor
|
Failures are known stackoverflow.cmd error and known Helix issue |
dhartglassMSFT
approved these changes
Feb 10, 2026
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124029