Make GetGetDotNetCert clone the certificate for reliability#124292
Merged
bartonjs merged 1 commit intodotnet:mainfrom Feb 12, 2026
Merged
Make GetGetDotNetCert clone the certificate for reliability#124292bartonjs merged 1 commit intodotnet:mainfrom
bartonjs merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
vcsjones
approved these changes
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Unix X509 filesystem test helper that fetches the get.dot.net certificate to return a cloned X509Certificate2, avoiding object lifetime/handle invalidation issues seen in CrlDiskCacheRecovers.
Changes:
- Clone the server certificate in
RemoteCertificateValidationCallbackby exporting it and re-loading viaX509CertificateLoader. - Add extra accesses/asserts of
Subjectto surface invalid-handle issues earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around an object lifetime issue in the new CrlDiskCacheRecovers test.
Contributes to #124279.