Skip to content

SPMI: Run superpmi-diffs on windows-x64#124343

Merged
jakobbotsch merged 7 commits intodotnet:mainfrom
jakobbotsch:asmdiffs-on-linux
Feb 13, 2026
Merged

SPMI: Run superpmi-diffs on windows-x64#124343
jakobbotsch merged 7 commits intodotnet:mainfrom
jakobbotsch:asmdiffs-on-linux

Conversation

@jakobbotsch
Copy link
Copy Markdown
Member

@jakobbotsch jakobbotsch commented Feb 12, 2026

While osx-arm64 is the fastest Helix queues we have the AzDO pool is currently heavily overloaded and causes hour long waits before builds start or Helix jobs are even submitted. Switch to windows-x64 for diffs to avoid this.

While osx-arm64 is the fastest Helix queues we have the AzDO pool is
currently heavily overloaded and causes hour long waits before builds
start or Helix jobs are even submitted. Switch to linux-x64 for diffs to
avoid this.
Copilot AI review requested due to automatic review settings February 12, 2026 13:23
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 12, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CoreCLR SuperPMI diffs Azure Pipelines configuration to run diffs on linux_x64 instead of osx_arm64, reducing queue/start delays caused by the overloaded macOS AzDO pool.

Changes:

  • Switch SuperPMI diffs pipeline platform from osx_arm64 to linux_x64 for both the build and diffs jobs.
  • Remove the extra macOS-specific “Build SuperPMI (x64)” post-build step that was needed due to cross-arch tooling on macOS.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/coreclr/jit/importer.cpp Minor reordering of CORINFO_RESOLVED_TOKEN field assignments in impResolveToken.
eng/pipelines/coreclr/superpmi-diffs.yml Moves SuperPMI diffs execution/build from macOS arm64 to Linux x64 and removes macOS-only extra build step.

Comment thread src/coreclr/jit/importer.cpp Outdated
Comment thread eng/pipelines/coreclr/superpmi-diffs.yml Outdated
Comment thread eng/pipelines/coreclr/superpmi-diffs.yml Outdated
Copilot AI review requested due to automatic review settings February 12, 2026 15:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jakobbotsch jakobbotsch changed the title SPMI: Run superpmi-diffs on linux-x64 SPMI: Run superpmi-diffs on windows-x64 Feb 12, 2026
This reverts commit fa5513d.
Copilot AI review requested due to automatic review settings February 13, 2026 09:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@jakobbotsch jakobbotsch requested a review from EgorBo February 13, 2026 10:04
@jakobbotsch jakobbotsch merged commit 52f93b5 into dotnet:main Feb 13, 2026
122 of 124 checks passed
@jakobbotsch jakobbotsch deleted the asmdiffs-on-linux branch February 13, 2026 12:03
richlander pushed a commit to richlander/runtime that referenced this pull request Feb 14, 2026
While osx-arm64 is the fastest Helix queues we have the AzDO pool is
currently heavily overloaded and causes hour long waits before builds
start or Helix jobs are even submitted. Switch to windows-x64 for diffs
to avoid this.
iremyux pushed a commit to iremyux/dotnet-runtime that referenced this pull request Mar 2, 2026
While osx-arm64 is the fastest Helix queues we have the AzDO pool is
currently heavily overloaded and causes hour long waits before builds
start or Helix jobs are even submitted. Switch to windows-x64 for diffs
to avoid this.
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants