[HTTP] Remove stale ActiveIssue overrides for #72586 #124384
Merged
ManickaP merged 1 commit intodotnet:mainfrom Feb 16, 2026
Merged
[HTTP] Remove stale ActiveIssue overrides for #72586 #124384ManickaP merged 1 commit intodotnet:mainfrom
ManickaP merged 1 commit intodotnet:mainfrom
Conversation
…ConformanceTests Issue dotnet#72586 was closed (completed) in Oct 2022. The three test method overrides that returned Task.CompletedTask are no longer needed, allowing the base class CancelPending tests to run.
github-actions
Bot
added
the
needs-area-label
ManickaP
added
area-System.Net.Http
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes stale ActiveIssue-based overrides that were disabling response stream cancellation conformance tests for HTTP/1 response streams, allowing the shared ConnectedStreamConformanceTests coverage to run again now that #72586 is closed.
Changes:
- Removed three overridden test methods that returned
Task.CompletedTaskand were marked withActiveIssue(72586). - Re-enabled the base class
ReadAsync_CancelPending*conformance tests forHttp1CloseResponseStreamConformanceTestsandHttp1RawResponseStreamConformanceTests.
MihaZupan
approved these changes
Feb 13, 2026
This was referenced Feb 13, 2026
Open
wfurt
approved these changes
Feb 14, 2026
Member
Author
|
/ba-g unrelated infra issues, the re-enabled tests are not failing. |
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…4384) Issue dotnet#72586 was closed (completed) in Oct 2022. The three test method overrides that returned Task.CompletedTask are no longer needed, allowing the base class CancelPending tests to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #72586 was closed (completed) in Oct 2022. The three test method overrides that returned Task.CompletedTask are no longer needed, allowing the base class CancelPending tests to run.