Skip to content

Mark HTTP/1 trailer headers as unsupported on Browser#124466

Open
Copilot wants to merge 4 commits intomainfrom
copilot/implement-trailer-headers
Open

Mark HTTP/1 trailer headers as unsupported on Browser#124466
Copilot wants to merge 4 commits intomainfrom
copilot/implement-trailer-headers

Conversation

Copy link
Contributor

Copilot AI commented Feb 16, 2026

Description

HTTP/1 trailer headers are not implemented for Browser platform. Changed test attribute from ActiveIssue to SkipOnPlatform to reflect this is a permanent platform limitation, not a tracked bug.

Changes

  • Test Attributes: Replaced [ActiveIssue("https://github.com/dotnet/runtime/issues/54156", TestPlatforms.Browser)] with [SkipOnPlatform(TestPlatforms.Browser, "HTTP/1 trailers are not supported by most major browsers")] on SocketsHttpHandler_Http1_TrailingHeaders_Test

This aligns with the pattern used for other Browser platform limitations (proxies, certificates, sockets). The skip message clarifies that this is a browser limitation affecting HTTP/1 trailers specifically, not a .NET implementation issue.

Original prompt

This section details on the original issue you should resolve

<issue_title>[wasm] Trailer headers not implemented</issue_title>
<issue_description>As covered by unit test SocketsHttpHandler_Http1_TrailingHeaders_Test and https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Trailer</issue_description>

<agent_instructions>Replace the ActiveIssue with platform not supported (or what is it called)</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@ Tagging subscribers to this area: @dotnet/ncl See info in [area-owners.md](https://github.com/dotnet/runtime/blob/main/docs/area-owners.md) if you want to be subscribed.
Issue Details

As covered by unit test SocketsHttpHandler_Http1_TrailingHeaders_Test and https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Trailer

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http

Milestone: -

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@oroztocil
Copy link
Member

@copilot See the comment #54156 (comment)

Do not try to implement the feature. Just replace the ActiveIssue attribute on the SocketsHttpHandler_Http1_TrailingHeaders_Test with a platform not supported for browser.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 16, 2026
…n Browser

Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement trailer headers for HTTP handling Mark HTTP/1 trailer headers as unsupported on Browser Feb 16, 2026
Copilot AI requested a review from oroztocil February 16, 2026 15:05
@github-actions github-actions bot added area-System.Net.Http and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 16, 2026
…support

Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
@oroztocil oroztocil marked this pull request as ready for review February 16, 2026 15:40
Copilot AI review requested due to automatic review settings February 16, 2026 15:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates System.Net.Http functional tests to reflect that HTTP/1 trailer headers are a Browser platform limitation rather than an active product issue.

Changes:

  • Replaced ActiveIssue with SkipOnPlatform for the HTTP/1 trailing headers test on Browser.
  • Updated the skip message to clarify that most major browsers don’t support HTTP/1 trailers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] Trailer headers not implemented

3 participants