Allow box_this pattern on composite r2r#124519
Open
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
For the following code:
```
struct MyStruct
{
public int Value;
}
static string CallToString<T>(ref T val) where T : struct
{
// constrained. T callvirt ToString()
return val.ToString();
}
var s = new MyStruct { Value = 42 };
Console.WriteLine(CallToString(ref s));
```
The CallToString method would be skipped by r2r because, in this state, if user would change MyStruct to contain an override for `ToString` then the generated code for CallToString would be incorrect since it should no longer do any boxing. For composite r2r however, this is not a problem if the valuetype (MyStruct) and the compiled method (CallToString) are in the same version bubble. The fix adds a check that these are in the same version bubble.
This was referenced Feb 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the following code:
The CallToString method would be skipped by r2r because, in this state, if user would change MyStruct to contain an override for
ToStringthen the generated code for CallToString would be incorrect since it should no longer do any boxing. For composite r2r however, this is not a problem if the valuetype (MyStruct) and the compiled method (CallToString) are in the same version bubble. The fix adds a check that these are in the same version bubble.