-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add tests for Volatile.ReadBarrier and Volatile.WriteBarrier #124558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
92ee330
Initial plan
Copilot 45d37a8
Add basic tests for Volatile.ReadBarrier and Volatile.WriteBarrier
Copilot 9db1630
Add tests for calling Volatile.ReadBarrier and WriteBarrier via refle…
Copilot 9b482b2
Consolidate tests into single comprehensive BarriersAndVolatileOperat…
Copilot d3e7262
Remove delegate invocation test as requested
Copilot cd3d286
Move reflection tests to separate test method
Copilot e933e93
Apply suggestions from code review
jkotas aaaa2d2
Combine smoke tests, reorder reflection test, and add cross-thread vo…
Copilot 2cede1b
Use ReadBarrier/WriteBarrier instead of Read/Write in cross-thread test
Copilot 6cdfba9
Remove cross-thread test since Task.Run and SpinOnce already involve …
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Reflection; | ||
| using Xunit; | ||
|
|
||
| namespace System.Threading.Tests | ||
| { | ||
| public class VolatileTests | ||
| { | ||
| [Fact] | ||
| public void Barriers_DoNotThrow() | ||
| { | ||
| Volatile.ReadBarrier(); | ||
| Volatile.WriteBarrier(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void BarriersViaReflection() | ||
| { | ||
| MethodInfo readBarrierMethod = typeof(Volatile).GetMethod(nameof(Volatile.ReadBarrier), BindingFlags.Public | BindingFlags.Static); | ||
| MethodInfo writeBarrierMethod = typeof(Volatile).GetMethod(nameof(Volatile.WriteBarrier), BindingFlags.Public | BindingFlags.Static); | ||
| Assert.NotNull(readBarrierMethod); | ||
| Assert.NotNull(writeBarrierMethod); | ||
| readBarrierMethod.Invoke(null, null); | ||
| writeBarrierMethod.Invoke(null, null); | ||
| } | ||
stephentoub marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [Fact] | ||
| public void BarriersAndVolatileOperations() | ||
| { | ||
| int value1 = 0; | ||
| int value2 = 0; | ||
| long value3 = 0; | ||
|
|
||
| Volatile.ReadBarrier(); | ||
| Volatile.WriteBarrier(); | ||
|
|
||
| Volatile.Write(ref value1, 42); | ||
| Volatile.WriteBarrier(); | ||
| Assert.Equal(42, value1); | ||
|
|
||
| Volatile.ReadBarrier(); | ||
| int result1 = Volatile.Read(ref value1); | ||
| Assert.Equal(42, result1); | ||
|
|
||
| Volatile.ReadBarrier(); | ||
| Volatile.ReadBarrier(); | ||
| Volatile.WriteBarrier(); | ||
| Volatile.WriteBarrier(); | ||
|
|
||
| Volatile.Write(ref value2, 100); | ||
| Volatile.WriteBarrier(); | ||
| Volatile.ReadBarrier(); | ||
| int result2 = Volatile.Read(ref value2); | ||
| Assert.Equal(100, result2); | ||
|
|
||
| Volatile.Write(ref value3, 123456789L); | ||
| Volatile.ReadBarrier(); | ||
| long result3 = Volatile.Read(ref value3); | ||
| Assert.Equal(123456789L, result3); | ||
| } | ||
stephentoub marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.