Log and restore XmlNodeType in XmlNodeReader#124559
Open
lilinus wants to merge 3 commits intodotnet:mainfrom
Open
Log and restore XmlNodeType in XmlNodeReader#124559lilinus wants to merge 3 commits intodotnet:mainfrom
lilinus wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
....Xml/tests/XmlNodeReader/System.Xml.XmlNodeReader.Tests/XmlNodeReaderMoveToAttributeTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment on lines
+129
to
+134
| XmlNodeReader nodeReader = NodeReaderTestHelper.CreateNodeReader(xml); | ||
| Assert.True(nodeReader.ReadToDescendant("child")); | ||
| Assert.True(nodeReader.MoveToAttribute("attr1")); | ||
| Assert.False(nodeReader.MoveToAttribute("attr2")); | ||
| nodeReader.ReadStartElement("child"); | ||
| } |
There was a problem hiding this comment.
The new regression test verifies success by calling ReadStartElement, but it doesn’t directly assert the reader state after MoveToAttribute("attr2") returns false. To better lock in the intended fix (reader position must be unchanged), add assertions that NodeType/Name (and/or Depth) are still those of the existing attribute (e.g., still on attr1) before calling ReadStartElement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34443