Fix abandoned jit regression tests#124605
Merged
EgorBo merged 6 commits intodotnet:mainfrom Feb 20, 2026
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Registers previously “abandoned” JIT regression tests so they’re picked up by the merged test runner, and updates the jit-regression-test skill documentation to reflect the registration requirement.
Changes:
- Add missing
Runtime_122254,Runtime_122288,Runtime_123583,Runtime_123790, andRuntime_124082test sources toRegression_ro_2.csproj. - Update
.github/skills/jit-regression-test/SKILL.mdto instruct registering tests in a merged Regression.csprojinstead of assuming glob inclusion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tests/JIT/Regression/Regression_ro_2.csproj |
Explicitly includes additional JitBlue/Runtime_* test source files so they are built/run by the merged runner. |
.github/skills/jit-regression-test/SKILL.md |
Updates contributor guidance around when to create a custom .csproj vs registering the .cs file in merged Regression projects. |
Comments suppressed due to low confidence (1)
.github/skills/jit-regression-test/SKILL.md:116
- Minor grammar: “Most tests only need the
.csfile … and being registered …” reads awkwardly; consider changing to “and be registered …” (or similar).
- **No .csproj needed for simple tests**: Most tests only need the `.cs` file in a separate `src/tests/JIT/Regression/JitBlue/Runtime_*/` folder and being registered in `Regression_ro_2.csproj`.
added 2 commits
February 19, 2026 22:24
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib The tests look like they don't need any outerloop to repro |
jakobbotsch
approved these changes
Feb 20, 2026
jakobbotsch
reviewed
Feb 20, 2026
This was referenced Feb 21, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
Found by @jakobbotsch. I didn't realize in the new model they have to be registered in one of the merged csproj, I thought they were included with a glob pattern. Also, adjust the skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by @jakobbotsch. I didn't realize in the new model they have to be registered in one of the merged csproj, I thought they were included with a glob pattern. Also, adjust the skill.