[cDAC] Add managed definitions for IXCLRData COM interfaces#124922
Merged
max-charlamb merged 2 commits intodotnet:mainfrom Feb 27, 2026
Merged
[cDAC] Add managed definitions for IXCLRData COM interfaces#124922max-charlamb merged 2 commits intodotnet:mainfrom
max-charlamb merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces managed [GeneratedComInterface] projections for additional IXCLRData* COM interfaces (from xclrdata.idl) and updates existing cDAC COM surface/implementations to use typed parameters instead of void*/void**.
Changes:
- Add managed definitions for many previously-missing
IXCLRData*interfaces and related structs. - Add
ICLRDataTarget2/ICLRDataTarget3managed definitions. - Update cDAC implementations and forwarders to match the updated COM method signatures.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs | Adds many new IXCLRData* interfaces and replaces void*/void** with typed parameters. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ICLRData.cs | Adds ICLRDataTarget2 and ICLRDataTarget3 interface definitions. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataFrame.cs | Updates IXCLRDataFrame / IXCLRDataFrame2 implementation signatures to match new interface definitions. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataMethodInstance.cs | Updates method instance implementation signatures and related COM-pointer plumbing. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs | Updates module implementation signatures to match new interface definitions. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs | Updates task implementation signatures to match new interface definitions. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.IXCLRDataProcess.cs | Updates process implementation signatures to match new interface definitions. |
max-charlamb
force-pushed
the
cdac-add-interfaces
branch
from
c3beabb to
74e695c
Compare
noahfalk
approved these changes
Feb 27, 2026
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
The PR comments mention adding 14 new interfaces but some of the interfaces in that list already exist. For example: https://github.com/max-charlamb/runtime/blob/bb5c6c3425acf6f48d4d13521e6da1f5efe71b05/src/native/managed/cdacreader/src/Legacy/IXCLRData.cs#L346
Not a big deal, but it would be nice to get the right info there for posterity :)
Change AllocVirtual and FreeVirtual address parameters from ulong to ClrDataAddress to match CLRDATA_ADDRESS in clrdata.idl. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/ba-g cDAC only change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds managed
[GeneratedComInterface]definitions for IXCLRData* and ICLRData* COM interfaces fromxclrdata.idlandclrdata.idl.Changes
New interface definitions (IXCLRData.cs)
Added managed definitions for 14 interfaces that were previously missing:
IXCLRDataAppDomainIXCLRDataAssemblyIXCLRDataTypeDefinitionIXCLRDataTypeInstanceIXCLRDataMethodDefinitionIXCLRDataExceptionStateIXCLRDataValueIXCLRDataExceptionNotification/IXCLRDataExceptionNotification2/IXCLRDataExceptionNotification3/IXCLRDataExceptionNotification4/IXCLRDataExceptionNotification5IXCLRDataTarget3IXCLRLibrarySupportAlso added the
ClrDataMethodDefinitionExtentstruct.Note:
IXCLRDisassemblySupportandIXCLRDataDisplayare intentionally omitted because they use varargs (...) and non-HRESULT return types incompatible with[GeneratedComInterface].New interface definitions (ICLRData.cs)
Added managed definitions for 2 interfaces:
ICLRDataTarget2ICLRDataTarget3Also changed
ICLRDataTarget2.AllocVirtualandICLRDataTarget2.FreeVirtualaddress parameters fromulongtoClrDataAddressto matchCLRDATA_ADDRESSin the IDL.All GUIDs and vtable ordering verified against
src/coreclr/inc/xclrdata.idlandsrc/coreclr/inc/clrdata.idl.Files changed
ClrDataMethodDefinitionExtentstructICLRDataTarget2,ICLRDataTarget3, andClrDataAddressfix