Cache boundary delimiter strings in MultipartContent#124963
Open
cincuranet wants to merge 5 commits intodotnet:mainfrom
Open
Cache boundary delimiter strings in MultipartContent#124963cincuranet wants to merge 5 commits intodotnet:mainfrom
cincuranet wants to merge 5 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes System.Net.Http.MultipartContent boundary handling by caching the commonly-used boundary delimiter strings to reduce per-serialization string construction overhead and slightly reduce write calls during header serialization.
Changes:
- Precompute and store
_startBoundaryand_endBoundarystrings in theMultipartContentconstructor. - Reuse the cached boundary strings in
SerializeToStream,SerializeToStreamAsyncCore, andCreateContentReadStreamAsyncCore. - Reduce divider writes in
SerializeHeadersToStreamby writing the cached boundary string instead of piecemeal fragments.
rzikm
reviewed
Feb 27, 2026
src/libraries/System.Net.Http/src/System/Net/Http/MultipartContent.cs
Outdated
Show resolved
Hide resolved
This was referenced Feb 27, 2026
src/libraries/System.Net.Http/src/System/Net/Http/MultipartContent.cs
Outdated
Show resolved
Hide resolved
This was referenced Mar 5, 2026
Open
MihaZupan
reviewed
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-compute and cache _startBoundary and _endBoundary strings in the constructor to avoid repeated string concatenation on every call to SerializeToStream, SerializeToStreamAsync, and CreateContentReadStream. Also reduces the writes in SerializeHeadersToStream from 3 calls to 2.