Improve range analysis for checked bounds in GlobalAP#125056
Open
EgorBo wants to merge 4 commits intodotnet:mainfrom
Open
Improve range analysis for checked bounds in GlobalAP#125056EgorBo wants to merge 4 commits intodotnet:mainfrom
EgorBo wants to merge 4 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves CoreCLR JIT range analysis for unsigned comparisons against “checked bound” VNs (notably for Global Assertion Prop), allowing more precise constant-range tightening even when checked-bound symbolic limits can’t be used.
Changes:
- Extend
RangeCheck::MergeEdgeAssertionswith amaxDepthparameter to bound recursive refinement. - Add logic (when
canUseCheckedBounds == false) to infer non-negative constant ranges fromO2K_CHECKED_BOUND_ADD_CNSunsigned assertions (e.g., deriving[0..INT32_MAX-1]style ranges). - Recursively attempt to tighten the checked-bound VN’s own constant range (within a depth limit) before applying it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/rangecheck.h | Extends MergeEdgeAssertions signature with a recursion depth parameter. |
| src/coreclr/jit/rangecheck.cpp | Implements depth-limited recursive refinement and new unsigned checked-bound range tightening path for GlobalAP scenarios. |
This was referenced Mar 2, 2026
7896b89 to
1eb00ef
Compare
This was referenced Mar 3, 2026
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib a couple of improvements for range analysis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to find a few diffs.