Remove mcs stuff from linker test framework.#125223
Merged
sbomer merged 1 commit intodotnet:mainfrom Mar 5, 2026
Merged
Conversation
Contributor
Author
|
@sbomer please take a look |
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the remaining mcs-specific support and related test artifacts from the ILLink linker test framework, reflecting the decision that maintaining mcs-based coverage is no longer worthwhile.
Changes:
- Removes the
mcscompilation path (and related external-compiler plumbing) from the test case compiler. - Deletes the mcs-specific test case and its dependency/resource files.
- Updates test project content and generated analyzer test suite to drop the removed mcs test entry.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/TestCaseCompiler.cs | Removes mcs/external compiler support and narrows accepted CompilerToUse values. |
| src/tools/illink/test/Mono.Linker.Tests.Cases/TestFramework/Dependencies/CanCompileTestCaseWithMcs_Lib.cs | Deletes mcs-only supporting source file. |
| src/tools/illink/test/Mono.Linker.Tests.Cases/TestFramework/Dependencies/CanCompileTestCaseWithMcs.txt | Deletes mcs-only resource file. |
| src/tools/illink/test/Mono.Linker.Tests.Cases/TestFramework/CanCompileTestCaseWithMcs.cs | Deletes mcs-only test case. |
| src/tools/illink/test/Mono.Linker.Tests.Cases/Mono.Linker.Tests.Cases.csproj | Removes content inclusion for deleted mcs resource. |
| src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/generated/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.TestCaseGenerator/TestFrameworkTests.g.cs | Removes the generated test method for the deleted mcs test case. |
src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/TestCaseCompiler.cs
Show resolved
Hide resolved
src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/TestCaseCompiler.cs
Show resolved
Hide resolved
Unity was the last reason to keep this around. We used mcs as a source of different IL for testing code we have that makes changes to method bodies. The time has come that the added test coverage we use it for isn't worth the maintenance costs anymore. I'm going to remove mcs from our test setup which means there's no reason to keep this code around anymore.
mrvoorhe
force-pushed
the
linker-remove-mcs-stuff
branch
from
2b5d42e to
4863981
Compare
This was referenced Mar 5, 2026
Open
sbomer
approved these changes
Mar 5, 2026
Member
|
/ba-g "Timeouts and unrelated failure (#125051)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity was the last reason to keep this around. We used mcs as a source of different IL for testing code we have that makes changes to method bodies. The time has come that the added test coverage we use it for isn't worth the maintenance costs anymore. I'm going to remove mcs from our test setup which means there's no reason to keep this code around anymore.