fixes validation of stubbed methods#125224
Closed
adrianoc-unity3d wants to merge 1 commit intodotnet:mainfrom
Closed
fixes validation of stubbed methods#125224adrianoc-unity3d wants to merge 1 commit intodotnet:mainfrom
adrianoc-unity3d wants to merge 1 commit intodotnet:mainfrom
Conversation
The convertion of arrays of strings to a HashSet<string> was removing duplicates. This would lead to false positives when comparing the result of stubbing a method with 2 or more locals of the same type since both the expectation as well the actual values would contain a single entry.
dotnet-policy-service
Bot
added
linkable-framework
github-actions
Bot
added
the
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
Author
|
@dotnet-policy-service agree company="Unity Technologies" |
3 tasks
Contributor
Author
|
we found some issues with these changes; we'll open another PR with more changes from a different branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion of arrays of strings to a HashSet was removing duplicates. This would lead to false positives when comparing the result of stubbing a method with 2 or more locals of the same type since both the expectation as
well the actual values would contain a single entry.
The same issue was present when comparing method instructions.