Re-enable PlatformHandlerTest_Cookies_Http2 for WinHttpHandler#125261
Open
ManickaP wants to merge 1 commit intodotnet:mainfrom
Open
Re-enable PlatformHandlerTest_Cookies_Http2 for WinHttpHandler#125261ManickaP wants to merge 1 commit intodotnet:mainfrom
ManickaP wants to merge 1 commit intodotnet:mainfrom
Conversation
PlatformHandlerTest_Cookies_Http2 from WinHttpHandler test builds. The test was disabled in March 2020 due to WinHttp error 12030 (connection terminated abnormally) during HTTP/2 cookie tests. The WinHttpHandler has received significant updates since then. Fixes dotnet#33930 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
The original root cause was closing the server before client finishes processing the request and WinHTTP discarding the buffered data. |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the previously disabled HTTP/2 cookies functional test class for WinHttpHandler, aligning WinHttpHandler coverage with other handlers and addressing #33930 by removing a compile-time exclusion.
Changes:
- Removed the
#if !WINHTTPHANDLER_TESTpreprocessor guard that excludedPlatformHandlerTest_Cookies_Http2from WinHttpHandler test builds.
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33930
Summary
Removes the
#if !WINHTTPHANDLER_TESTpreprocessor guard that was disabling the entirePlatformHandlerTest_Cookies_Http2test class for WinHttpHandler.Validation
GetAsync_ReceiveSetCookieHeadertests on Windows (both net11.0 and net481 TFMs).