SoftMax: Multiply by 1 / expSum instead of dividing by expSum#125269
Open
BarionLP wants to merge 1 commit intodotnet:mainfrom
Open
SoftMax: Multiply by 1 / expSum instead of dividing by expSum#125269BarionLP wants to merge 1 commit intodotnet:mainfrom
1 / expSum instead of dividing by expSum#125269BarionLP wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
This was referenced Mar 6, 2026
Open
Contributor
Author
|
i think the build fails are unrelated? |
Contributor
Author
|
would it make sense to change the implementation of Divide too? public static void Divide(ReadOnlySpan<float> x, float y, Span<float> destination) =>
InvokeSpanScalarIntoSpan<MultiplyOperator_Single>(x, 1 / y, destination);is there a reason SoftMax calls |
Contributor
Author
|
i just realized that if x and y are very large the difference between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Numerics.Tensors.TensorPrimitives.SoftMax:We can convert a bunch of divisions to multiplications by calculating
1 / expSumonce and then multiplying.I assume this will slightly change the output of SoftMax but since float operations aren't consistent across platforms this should not matter.
Benchmark results
I assume this largely depends on the hardware
code: https://gist.github.com/BarionLP/aff1bca0d507dfb16f52bb715e3a58a2
late follow up to #111615