Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…nmentVariablesConfigurationProvider Co-authored-by: rosebyte <14963300+rosebyte@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review provider names for new connection strings
Add provider names for newly supported Azure connection string prefixes in EnvironmentVariablesConfigurationProvider
Mar 9, 2026
rosebyte
reviewed
Mar 13, 2026
| } | ||
| else if (key.StartsWith(ApiHubPrefix, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| HandleMatchedConnectionStringPrefix(data, ApiHubPrefix, null, key, value); |
Member
There was a problem hiding this comment.
@copilot , why this one and CustomConnectionStringPrefix one don't have any full key?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #116037, which added Azure App Service connection string prefix support but left provider names as
nullfor 5 of the 6 new prefixes.Changes
Provider names assigned for the following
CONNSTR_prefixes:DOCDBCONNSTR_Microsoft.Azure.CosmosEVENTHUBCONNSTR_Azure.Messaging.EventHubsNOTIFICATIONHUBCONNSTR_Microsoft.Azure.NotificationHubsREDISCACHECONNSTR_StackExchange.RedisSERVICEBUSCONNSTR_Azure.Messaging.ServiceBusAPIHUBCONNSTR_null(no specific provider)Tests updated —
LoadsAzureServiceConnectionStringsnow asserts_ProviderNamevalues instead of asserting their absence.Notes
MySql.Data.MySqlClient,Npgsql,System.Data.SqlClient).Microsoft.Azure.NotificationHubsuses the older SDK namespace. Reviewers should confirm whetherAzure.Messaging.NotificationHubs(newerAzure.Messaging.*pattern) is preferred.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.