-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix missing call to write barrier in static constructors of ref structs #125418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janvorli
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
janvorli:fix-refclass-contructor-codegen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9696b40
Fix missing call to write barrier in static constructors of ref structs
janvorli 5726aeb
PR feedback - Formal changes to the test
janvorli bb6adfe
Make the test class public
janvorli a87c7fa
Merge branch 'main' into fix-refclass-contructor-codegen
janvorli 4b1ce7d
Make test resilient to optimizations
janvorli 69a3960
More test updates based on feedback
janvorli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/tests/JIT/Regression/JitBlue/Runtime_125169/Runtime_125169.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
janvorli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| using System; | ||
| using Xunit; | ||
|
|
||
| public readonly struct ByteArrayWrapper | ||
| { | ||
| public readonly byte[] _innerArray; | ||
|
|
||
| public ByteArrayWrapper(scoped in byte[] innerArray) | ||
| { | ||
| _innerArray = innerArray; | ||
| } | ||
| } | ||
|
|
||
| public readonly ref struct RefWrapper | ||
| { | ||
| public static readonly ByteArrayWrapper _data = new ByteArrayWrapper(new byte[] { 0, 1, 2, 3, 4 }); | ||
| } | ||
|
|
||
| public class Runtime_125169 | ||
| { | ||
| // Regression test for bug in JIT where ref struct static fields of reference type initialized in | ||
| // its static constructor were missing calls to JIT_ByRefWriteBarrier for each such static field. | ||
| [Fact] | ||
| public static void TestEntryPoint() | ||
| { | ||
| byte[][] arr = new byte[100][]; | ||
| // Generate enough garbage | ||
| for (int i = 0; i < 100; i++) | ||
| { | ||
| arr[i] = new byte[100000]; | ||
| } | ||
|
|
||
| ReadOnlySpan<byte> testSpan = new(RefWrapper._data._innerArray); | ||
| // Without the fix, the following GC.Collect call causes fatal error during heap verification with DOTNET_HeapVerify=1 | ||
| GC.Collect(0); | ||
|
|
||
| // Prevent the compiler from optimizing out the loop above. | ||
| GC.KeepAlive(arr); | ||
janvorli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| for (int i = 0; i < testSpan.Length; i++) | ||
| { | ||
| Assert.Equal(i, testSpan[i]); | ||
| } | ||
| } | ||
janvorli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.