[browser][CoreCLR] startup helpers cleanup#125429
Merged
pavelsavara merged 7 commits intodotnet:mainfrom Mar 12, 2026
Merged
Conversation
Member
pavelsavara
commented
Mar 11, 2026
- make the run method more readable by forEachResource and normalizeCollection helpers
- callLibraryInitializerOnRuntimeConfigLoaded and callLibraryInitializerOnRuntimeReady in the assets.ts
…ollection helpers - callLibraryInitializerOnRuntimeConfigLoaded and callLibraryInitializerOnRuntimeReady in the assets.ts
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the browser/CoreCLR JS loader bootstrap flow to improve readability by introducing helpers for iterating optional resource collections, and centralizes library-initializer invocation logic into assets.ts.
Changes:
- Adds
forEachResource/normalizeCollectionhelpers to simplify optional resource handling increateRuntime. - Moves
onRuntimeConfigLoaded/onRuntimeReadylibrary-initializer invocation intoassets.ts. - Adjusts the runtime bootstrap sequence to use the new helpers and initializer functions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/native/libs/Common/JavaScript/loader/run.ts |
Refactors runtime creation flow, introduces resource-iteration helpers, and rewires library initializer invocation. |
src/native/libs/Common/JavaScript/loader/assets.ts |
Adds exported helpers to invoke library initializer hooks at config-loaded and runtime-ready phases. |
ilonatommy
approved these changes
Mar 11, 2026
This was referenced Mar 11, 2026
Open
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/ba-g unrelated failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.