Add html.escape to func_name in superpmi diffs report#125442
Merged
jakobbotsch merged 2 commits intomainfrom Mar 11, 2026
Merged
Add html.escape to func_name in superpmi diffs report#125442jakobbotsch merged 2 commits intomainfrom
jakobbotsch merged 2 commits intomainfrom
Conversation
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
PTAL @dotnet/jit-contrib. Had a case where a function with name |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the SuperPMI asm diffs markdown report against HTML interpretation issues by escaping method names that may contain characters like <, >, and & when rendered inside HTML <summary> elements.
Changes:
- Import Python’s
htmlmodule insuperpmi.py. - HTML-escape
func_namewhen composing theDetailsSectionheader for example diffs.
EgorBo
approved these changes
Mar 11, 2026
Member
|
/ba-g Timeouts |
Copilot AI
added a commit
that referenced
this pull request
Mar 13, 2026
Method names in asm diffs examples can contain characters like `<`, `>`, and `&` (e.g. generic type parameters). This PR adds `html.escape()` to `func_name` when it is rendered in the `DetailsSection` header of the superpmi diffs report, preventing those characters from being interpreted as HTML. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method names in asm diffs examples can contain characters like
<,>, and&(e.g. generic type parameters). This PR addshtml.escape()tofunc_namewhen it is rendered in theDetailsSectionheader of the superpmi diffs report, preventing those characters from being interpreted as HTML.