Fix OleTxTests.Recovery CI timeout by bounding remote process wall-clock time

[Copilot]

Description

OleTxTests.Recovery repeatedly times out the CI work item (the entire System.Transactions.Local.Tests work item is killed). The CI error gives no detail beyond the timeout — no stack traces or indication of where the hang occurs.

The most likely scenario is that MSDTC is unresponsive on certain CI machines, causing the child process spawned by RemoteExecutor.Invoke to hang (either stuck in MSDTC COM interop, or sitting in its intentional Thread.Sleep waiting for a commit callback that never arrives). Since RemoteInvokeOptions.TimeOut defaults to Timeout.Infinite, RemoteInvokeHandle.Dispose() blocks indefinitely waiting for the child to exit, and the test never completes.

It's also possible the main test thread hangs in tx.Commit() or one of the WaitOne(Timeout) calls. This change would not help in that case — only the child process is bounded. If the timeout continues to repro after this change, the main thread is the more likely culprit and would need its own timeout or the test should be skipped on affected CI legs.

Change:

• Add TimeOut = 120_000 to RemoteInvokeOptions so RemoteInvokeHandle.Dispose() will force-kill the child process after 2 minutes (with a diagnostic dump at the halfway point) instead of blocking indefinitely. This bounds the test's wall-clock time and should prevent it from consuming the entire work item timeout budget.

Changes

• src/libraries/System.Transactions.Local/tests/OleTxTests.cs

Testing

This change targets a flaky/hanging test; no new test logic is added. The fix will be validated by the reduction in CI work item timeouts on Windows runs. The test requires MSDTC and cannot be run locally in most environments (the ConditionalFact skips it when MSDTC is unavailable).

• Fixes System.Transactions.Tests.OleTxTests.Recovery timeout #122621

[dotnet-policy-service]

Tagging subscribers to this area: @SamMonoRT, @dotnet/efteam
See info in area-owners.md if you want to be subscribed.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.