Disable attribute trimming android 124958#125863
Merged
vitek-karas merged 2 commits intodotnet:mainfrom Mar 21, 2026
Merged
Conversation
Temporarily disable the NativeAOT smoke test on Android while issue dotnet#124958 is investigated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the NativeAOT AttributeTrimming smoke test when targeting Android to avoid intermittent/unpredictable trimming outcomes caused by additional Android hosting/interop code influencing the linker, aligning with the failure described in #124958.
Changes:
- Mark
AttributeTrimmingas unsupported on Android viaCLRTestTargetUnsupported. - Add an explanatory comment documenting why Android is excluded.
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
MichalStrehovsky
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable AttributeTrimming test on Android.
The test is very sensitive to specific trimming behavior, but running it on Android adds a lot of code from the Android hosting/interop which influences trimming and thus makes the test unpredictable.
Fixes #124958