SPMI: Fix invalid format string and allow parsing full uint32 range

[jakobbotsch]

Noticed that e.g. DOTNET_JitHashBreak=9b29601d hits the error path below, which hits an assert due to %ws. Fix the format string, and then also fix the parsing so that it works properly when the upper bit is set.

PTAL @dotnet/jit-contrib

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR fixes SuperPMI JIT host configuration parsing/logging so hex config values like DOTNET_JitHashBreak=9b29601d no longer hit an assert and can be accepted across the full uint32 range.

Changes:

• Fix LogWarning format specifiers to correctly print UTF-8 char* strings (%s instead of %ws).
• Relax hex parsing range check from INT_MAX to UINT_MAX to allow values with the high bit set.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/coreclr/tools/superpmi/superpmi/jithost.cpp:128

• Allowing values up to UINT_MAX means longResult can be > INT_MAX, but the code then does result = static_cast<int>(longResult). Converting an out-of-range unsigned value to int is implementation-defined, and it’s easy to lose the intended 32-bit bit-pattern on non-two’s-complement/odd platforms. If the goal is to accept any 32-bit value (e.g. method hashes with the high bit set), consider parsing into a uint32_t and then copying/bit-casting into the int result with a static_assert(sizeof(int) == sizeof(uint32_t)), so the bit pattern is preserved deterministically.

    unsigned long longResult = strtoul(stringValue, &endPtr, 16);
    bool          succeeded  = (errno != ERANGE) && (endPtr != stringValue) && (longResult <= UINT_MAX);
    if (!succeeded)
    {
        LogWarning("Can't convert int config value from string, key: %s, string value: %s\n", key, stringValue);
        return false;
    }

    result = static_cast<int>(longResult);
    return true;