Simplify arithmetic operations on registry and memory in ssa

[pedrobsaila]

Fixes #125300

Alternate version of #125559 (cc @EgorBo )

Before :

Program:AddReg(int):int (FullOpts):
       lea      eax, [rdi+2*rdi]
       ret      

Program:AddMem(byref):int (FullOpts):
       mov      eax, dword ptr [rdi]
       lea      ecx, [rax+rax]
       add      eax, ecx
       ret      

Program:SubReg(int):int (FullOpts):
       xor      eax, eax
       sub      eax, edi
       ret      

Program:SubMem(byref):int (FullOpts):
       mov      eax, dword ptr [rdi]
       mov      ecx, eax
       sub      ecx, eax
       sub      ecx, eax
       mov      eax, ecx
       ret  

After:

Program:AddReg(int):int (FullOpts):
       lea      eax, [rdi+2*rdi]
       ret      

Program:AddMem(byref):int (FullOpts):
       mov      eax, dword ptr [rdi]
       lea      eax, [rax+2*rax]
       ret      

Program:SubReg(int):int (FullOpts):
       mov      eax, ecx
       neg      eax
       ret      

Program:SubMem(byref):int (FullOpts):
       mov      eax, dword ptr [rdi]
       neg      eax
       ret 

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[EgorBo]

I haven't looked into correctness of these changes, but the diffs look like a PerfScore regression accross all collections?

[pedrobsaila]

One of the things that I don't understand in asm diffs is this :

       lea      eax, [rax+rax+0x03]
						;; size=29 bbWeight=1 PerfScore 5.25

less size than this :

       lea      eax, [2*rax+0x03]
						;; size=32 bbWeight=1 PerfScore 4.75

Is there a logical explanation for it ?

For the perf score diffs I'm working on fixing them

[EgorBo]

TBH, I am not sure what SSA in the PR title means - you just moved morph logic to this place which doesn't make sense to me, morph is supposed to be called from this phase (if it is not, we can experiment calling it unconditionally as today it might be called only if we constant folded something or changed based on assertions).

this function is a good place to, in theory, to rely on SSA, but the current PR doesn't do it.