[cDAC] : Implement ClrDataModule GetName by rcj1 · Pull Request #125942 · dotnet/runtime

rcj1 · 2026-03-23T01:55:20Z

No description provided.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8d8354fa-39ad-4227-b870-1b29a92a587f

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/39def273-a823-4c95-9f33-063d207f30d7

dotnet-policy-service · 2026-03-23T01:56:32Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Implements IXCLRDataModule.GetName in the cDAC legacy shim by sourcing the module “simple name” from the Loader contract, and extends the Loader contract/data model to surface that simple name from the target runtime.

Changes:

Add Module.SimpleName (UTF-8) to the Module data model + mock descriptors and implement ILoader.GetSimpleName.
Implement ClrDataModule.GetName using ILoader.GetSimpleName.
Add tests for GetSimpleName and implement UTF-8 string reading in the test target; update Loader contract docs accordingly.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/TestPlaceholderTarget.cs	Implements `ReadUtf8String` for test targets.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.cs	Adds `Module.SimpleName` to mock Module field descriptors.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Loader.cs	Extends module mock builder to allocate/write a UTF-8 simple name.
src/native/managed/cdac/tests/LoaderTests.cs	Adds `GetSimpleName` coverage across architectures.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs	Implements `IXCLRDataModule.GetName` via Loader contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Module.cs	Adds `SimpleName` pointer to `Data.Module` materialization.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs	Adds `ILoader.GetSimpleName` implementation (currently in v1 contract impl).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs	Adds `GetSimpleName` to Loader abstraction interface.
src/coreclr/vm/ceeload.h	Adds `cdac_data<Module>::SimpleName` offset for contracts.
docs/design/datacontracts/Loader.md	Documents `GetSimpleName` API + `Module.SimpleName` field + pseudocode.

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs

docs/design/datacontracts/Loader.md

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs

src/coreclr/vm/ceeload.h

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Module.cs

docs/design/datacontracts/Loader.md

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs

…er.Contracts/Contracts/Loader_1.cs Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs

src/native/managed/cdac/tests/TestPlaceholderTarget.cs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs

Copilot · 2026-03-24T14:45:27Z

@rcj1 I've opened a new pull request, #126030, to work on those changes. Once the pull request is ready, I'll request review from you.

rcj1 · 2026-03-24T14:45:56Z

@copilot STOP!!!

Copilot · 2026-03-24T14:46:05Z

@rcj1 I've opened a new pull request, #126031, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0e43d4be-e4a7-4497-9940-81a4b3a67490

rcj1 · 2026-03-24T20:36:30Z

/ba-g timeouts

Copilot AI and others added 3 commits March 22, 2026 21:51

implement cDAC IXCLRDataModule::GetName via new Loader API GetSimpleName

d3320e0

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8d8354fa-39ad-4227-b870-1b29a92a587f

fixup: throw E_FAIL and fix Loader.md GetSimpleName pseudocode

f245be5

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/39def273-a823-4c95-9f33-063d207f30d7

Update ClrDataModule.cs

e8b7346

rcj1 requested review from barosiak, Copilot, max-charlamb and noahfalk March 23, 2026 01:55

dotnet-policy-service bot assigned rcj1 Mar 23, 2026

github-actions bot added the area-Diagnostics-coreclr label Mar 23, 2026

Copilot started reviewing on behalf of rcj1 March 23, 2026 01:56 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

rcj1 marked this pull request as draft March 23, 2026 02:06

rcj1 removed request for barosiak, max-charlamb and noahfalk March 23, 2026 02:06

build-analysis bot mentioned this pull request Mar 23, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

rcj1 added 2 commits March 23, 2026 13:53

e

7f240e4

code review

46a89fd

noahfalk approved these changes Mar 23, 2026

View reviewed changes

docs/design/datacontracts/Loader.md Show resolved Hide resolved

hoyosjs reviewed Mar 24, 2026

View reviewed changes

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs Outdated Show resolved Hide resolved

Update src/native/managed/cdac/Microsoft.Diagnostics.DataContractRead…

ba8945c

…er.Contracts/Contracts/Loader_1.cs Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 24, 2026 00:54

Copilot started reviewing on behalf of rcj1 March 24, 2026 00:55 View session

hoyosjs marked this pull request as ready for review March 24, 2026 00:56

hoyosjs approved these changes Mar 24, 2026

View reviewed changes

Copilot AI reviewed Mar 24, 2026

View reviewed changes

This was referenced Mar 24, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

Update TestPlaceholderTarget.cs

51cbee2

Copilot AI review requested due to automatic review settings March 24, 2026 14:04

Copilot started reviewing on behalf of rcj1 March 24, 2026 14:05 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs Show resolved Hide resolved

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs Show resolved Hide resolved

Copilot AI mentioned this pull request Mar 24, 2026

[WIP] [WIP] Add unit test for TryGetSimpleName with invalid UTF-8 handling feedback #126030

Closed

Copilot AI mentioned this pull request Mar 24, 2026

[WIP] [cDAC] Implement ClrDataModule GetName #126031

Closed

test: add TryGetSimpleName_InvalidUtf8 unit test

18bed2f

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0e43d4be-e4a7-4497-9940-81a4b3a67490

rcj1 merged commit d69ff06 into main Mar 24, 2026
99 of 110 checks passed

rcj1 deleted the copilot/implement-cdac-api-getname branch March 24, 2026 20:36

dotnet-maestro bot mentioned this pull request Mar 25, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5691

Open

Conversation

rcj1 commented Mar 23, 2026

Uh oh!

dotnet-policy-service bot commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 24, 2026

Uh oh!

rcj1 commented Mar 24, 2026

Uh oh!

Copilot AI commented Mar 24, 2026

Uh oh!

rcj1 commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants