Skip to content

Fix Mono-style whitespace in UnsafeMethodMissingRequiresUnsafeAnalyze… #125943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichalStrehovsky wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −21
Open

Fix Mono-style whitespace in UnsafeMethodMissingRequiresUnsafeAnalyze… #125943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/UnsafeMethodMissingRequiresUnsafeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,65 +9,68 @@

namespace ILLink.RoslynAnalyzer
{
[DiagnosticAnalyzer (LanguageNames.CSharp)]
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public sealed class UnsafeMethodMissingRequiresUnsafeAnalyzer : DiagnosticAnalyzer
{
private static readonly DiagnosticDescriptor s_rule = DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.UnsafeMethodMissingRequiresUnsafe, diagnosticSeverity: DiagnosticSeverity.Info);
private static readonly DiagnosticDescriptor s_rule = DiagnosticDescriptors.GetDiagnosticDescriptor(DiagnosticId.UnsafeMethodMissingRequiresUnsafe, diagnosticSeverity: DiagnosticSeverity.Info);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create (s_rule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(s_rule);

public override void Initialize (AnalysisContext context)
public override void Initialize(AnalysisContext context)
{
context.EnableConcurrentExecution ();
context.ConfigureGeneratedCodeAnalysis (GeneratedCodeAnalysisFlags.None);
context.RegisterCompilationStartAction (context => {
if (!context.Options.IsMSBuildPropertyValueTrue (MSBuildPropertyOptionNames.EnableUnsafeAnalyzer))
context.EnableConcurrentExecution();
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
context.RegisterCompilationStartAction(context =>
{
if (!context.Options.IsMSBuildPropertyValueTrue(MSBuildPropertyOptionNames.EnableUnsafeAnalyzer))
return;

if (context.Compilation.GetTypeByMetadataName (RequiresUnsafeAnalyzer.FullyQualifiedRequiresUnsafeAttribute) is null)
if (context.Compilation.GetTypeByMetadataName(RequiresUnsafeAnalyzer.FullyQualifiedRequiresUnsafeAttribute) is null)
return;

context.RegisterSymbolAction (
context.RegisterSymbolAction(
AnalyzeMethod,
SymbolKind.Method);
});
}

private static void AnalyzeMethod (SymbolAnalysisContext context)
private static void AnalyzeMethod(SymbolAnalysisContext context)
{
if (context.Symbol is not IMethodSymbol method)
return;

if (!HasPointerInSignature (method))
if (!HasPointerInSignature(method))
return;

if (method.HasAttribute (RequiresUnsafeAnalyzer.RequiresUnsafeAttributeName))
if (method.HasAttribute(RequiresUnsafeAnalyzer.RequiresUnsafeAttributeName))
return;

// For property/indexer accessors, check the containing property instead
if (method.AssociatedSymbol is IPropertySymbol property
&& property.HasAttribute (RequiresUnsafeAnalyzer.RequiresUnsafeAttributeName))
&& property.HasAttribute(RequiresUnsafeAnalyzer.RequiresUnsafeAttributeName))
return;

foreach (var location in method.Locations) {
context.ReportDiagnostic (Diagnostic.Create (s_rule, location, method.GetDisplayName ()));
foreach (var location in method.Locations)
{
context.ReportDiagnostic(Diagnostic.Create(s_rule, location, method.GetDisplayName()));
}
}

private static bool HasPointerInSignature (IMethodSymbol method)
private static bool HasPointerInSignature(IMethodSymbol method)
{
if (IsPointerType (method.ReturnType))
if (IsPointerType(method.ReturnType))
return true;

foreach (var param in method.Parameters) {
if (IsPointerType (param.Type))
foreach (var param in method.Parameters)
{
if (IsPointerType(param.Type))
return true;
}

return false;
}

private static bool IsPointerType (ITypeSymbol type) => type is IPointerTypeSymbol or IFunctionPointerTypeSymbol;
private static bool IsPointerType(ITypeSymbol type) => type is IPointerTypeSymbol or IFunctionPointerTypeSymbol;
}
}
#endif
Loading