Fix flaky signal handler test on mono on Linux#125969
Merged
mrek-msft merged 2 commits intodotnet:mainfrom Mar 24, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a flaky System.Diagnostics.Process signal-handling test on Linux when running under the Mono interpreter, where SIGQUIT can emit a thread dump to stdout and break the parent process’ StandardOutput.EndOfStream assertion.
Changes:
- Updates
SignalHandler_CanDisposeInHandlerto terminate the remote process withSIGTERM(instead of a secondSIGQUIT) when running on Mono + non-Windows. - Adds a comment explaining Mono’s
SIGQUITbehavior that caused the flake.
jkotas
approved these changes
Mar 23, 2026
jkotas
reviewed
Mar 23, 2026
This was referenced Mar 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #125953
Issue was that in mono case, two signals were send, SIGQUIT, then SIGTERM. If remote process was fast enough, SIGQUIT printed thread dump on stdout and
StandardOutput.EndOfStreamcheck in parent failed afterwards.