Revert "Refactor loader heap backout adapter to remove multiple inheritance"#126033
Merged
Revert "Refactor loader heap backout adapter to remove multiple inheritance"#126033
Conversation
…itance (…" This reverts commit 509a2f1.
rcj1
requested review from
Copilot and
noahfalk
and removed request for
Copilot
Contributor
|
Tagging subscribers to this area: @agocke |
Member
|
What is the problem with this change? |
Contributor
Author
This does not solve the original problem, because still UnlockedLoaderHeapBase has a vptr while ExplicitControl does not. The original problem is solved by adding a virtual destructor on the base class. |
jkotas
approved these changes
Mar 24, 2026
Contributor
Author
|
/ba-g timeouts. simple revert and no changes to these files since commit that is reverted here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #125867