Draft
Conversation
Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/170e8a42-d696-415a-a397-af4f777ee568
Copilot created this pull request from a session on behalf of
max-charlamb
March 25, 2026 19:17
View session
Contributor
|
Tagging subscribers to this area: @agocke |
This was referenced Mar 26, 2026
Open
Member
|
@copilot, lets trim this PR down to just removing the LastReportedFuncletInfo struct. The other flag could in theory be used. |
…nfo deletion Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8fca3dc9-3d64-4bff-be2b-096e511c609f
Contributor
Author
Done — |
Copilot
AI
changed the title
Remove dead LastReportedFuncletInfo and ReportFPBasedSlotsOnly code
Remove dead LastReportedFuncletInfo struct
Mar 26, 2026
max-charlamb
approved these changes
Mar 26, 2026
janvorli
approved these changes
Mar 26, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #119863 moved CoreCLR EH second-pass logic to native code and removed all runtime usage of the funclet saved-slot reporting feature, but left behind an orphaned definition. This removes it.
Description
LastReportedFuncletInfostruct (vm/exinfo.h) — struct with no references anywhere in the codebase; deleted.No functional behavior changes — the removed struct was entirely unreachable.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.