Clean up stale Ubuntu references in comments and docs by richlander · Pull Request #126127 · dotnet/runtime

richlander · 2026-03-25T21:10:19Z

Note

This PR was AI/Copilot-generated (Copilot CLI v1.0.11).

Remove stale Ubuntu version references from comments and documentation:

docker-compose.yml comments (HttpStress + SslStress): Remove reference to old Build.Ubuntu.2204.Amd64.Open pool name — build pool has moved to Azure Linux 3
cross-building.md: Update FreeBSD cross-build example from ubuntu-18.04-cross-freebsd-12 to current azurelinux-3.0-net11.0-cross-freebsd-14-amd64 image
webassembly-instructions.md: Replace stale Ubuntu 18.04 Dockerfile paths, image tags, and master branch references with current links

dotnet-policy-service · 2026-03-25T21:11:31Z

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

- docker-compose.yml: remove obsolete version attribute from all three compose files (HttpStress, SslStress, EnterpriseTests) — the version key is ignored by docker compose v2 and only produces warnings - cross-building.md: update FreeBSD cross-build example from ubuntu-18.04-cross-freebsd-12 to current azurelinux-3.0 image - webassembly-instructions.md: replace stale Ubuntu 18.04 Dockerfile paths, image tags, and master branch references with current links Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Removes stale Ubuntu-version references from stress test docker-compose comments and build documentation, aligning examples with the repo’s current container/queue naming and external prereqs repos.

Changes:

Generalize docker-compose.yml comments to remove references to a specific Ubuntu build pool.
Update the CoreCLR FreeBSD cross-build Docker image example to an Azure Linux 3–based prereqs image.
Refresh WASM Docker image update instructions to point at newer prereqs/versions metadata locations.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

File	Description
src/libraries/System.Net.Security/tests/StressTests/SslStress/docker-compose.yml	Removes a specific Ubuntu pool reference from the `version:` comment.
src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml	Same comment cleanup as SslStress to avoid stale pool naming.
docs/workflow/building/libraries/webassembly-instructions.md	Updates links/instructions for updating the WASM prereqs image and where to find the resulting tag metadata.
docs/workflow/building/coreclr/cross-building.md	Updates the FreeBSD cross-build prereqs image tag in the Docker example.

Copilot · 2026-03-25T21:13:43Z

src/libraries/System.Net.Security/tests/StressTests/SslStress/docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3' # Although the version attribute is obsolete and should be ignored, it's seemingly not the case on Build.Ubuntu.2204.Amd64.Open
 services:


The comment refers to “docker compose” generically; to avoid confusion and match the official naming/CLI, consider using “Docker Compose” (or docker compose in code formatting if you mean the command).

Copilot · 2026-03-25T21:13:44Z

src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3' # Although the version attribute is obsolete and should be ignored, it's seemingly not the case on Build.Ubuntu.2204.Amd64.Open
 services:


The comment refers to “docker compose” generically; to avoid confusion and match the official naming/CLI, consider using “Docker Compose” (or docker compose in code formatting if you mean the command).

Copilot · 2026-03-25T21:13:44Z

docs/workflow/building/libraries/webassembly-instructions.md

 ## Updating Emscripten version in Docker image

-First update emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/master/src/ubuntu/18.04/webassembly/Dockerfile#L19).
+First update the emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/26.04/helix/webassembly/amd64/Dockerfile).


This doc links to a Dockerfile under src/ubuntu/26.04/..., but the runtime repo’s current WASM Helix container references are ubuntu-24.04-helix-webassembly-amd64 (and ubuntu-22.04-...). Please confirm the linked Dockerfile is the one that actually produces the images used by the runtime pipelines, or update the link to match the current image lineage.

Suggested change

First update the emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/26.04/helix/webassembly/amd64/Dockerfile).

First update the emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/24.04/helix/webassembly/amd64/Dockerfile).

Copilot · 2026-03-25T21:13:44Z

docs/workflow/building/libraries/webassembly-instructions.md

+Submit a PR request with the updated version, wait for all checks to pass and for the request to be merged. A [image-info.json file](https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json) will be updated with the new docker image tag.

-```
-{
-  "platforms": [
-    {
-      "dockerfile": "src/ubuntu/18.04/webassembly/Dockerfile",
-      "simpleTags": [
-        "ubuntu-18.04-webassembly-20210707133424-12f133e"
-      ],
-      "digest": "sha256:1f2d920a70bd8d55bbb329e87c3bd732ef930d64ff288dab4af0aa700c25cfaf",
-      "osType": "Linux",
-      "osVersion": "Ubuntu 18.04",
-      "architecture": "amd64",
-      "created": "2020-05-29T22:16:52.5716294Z",
-      "commitUrl": "https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/6a6da637580ec557fd3708f86291f3ead2422697/src/ubuntu/18.04/webassembly/Dockerfile"
-    }
-  ]
-},
-```
-
-Copy the docker image tag and replace it in [platform-matrix.yml](https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/platform-matrix.yml#L172)
-
-```
-container:
-    image: ubuntu-18.04-webassembly-20210707133424-12f133e
-    registry: mcr
-```
+Copy the docker image tag and update the references in the runtime repo pipeline files (e.g., `eng/pipelines/helix-platforms.yml` and `eng/pipelines/libraries/helix-queues-setup.yml`).

 Open a PR request with the new image.


A few wording/link-text issues: “PR request” is redundant (PR = pull request), and the link text “image-info.json file” doesn’t match the actual filename being linked. Also, “A image-info…” should be “An …”. Tightening this wording will make the instructions clearer.

- Link to 24.04 Dockerfile (current) instead of 26.04 (not yet in use) - Fix 'PR request' redundancy → 'PR' - Fix 'A image-info.json file' → 'The image-info manifest' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-25T23:14:17Z

🤖 Copilot Code Review — PR #126127

Holistic Assessment

Motivation: The PR cleans up stale Ubuntu 18.04 references across documentation and configuration files. Ubuntu 18.04 reached EOL in 2023 and the repo's build infrastructure has migrated to AzureLinux 3.0. These references were actively misleading for contributors — the problem is clearly real and well-scoped.

Approach: Correct approach — surgical updates to documentation links, Docker image tags, and removal of an obsolete docker-compose version attribute. No functional code changes.

Summary: ✅ LGTM. This is a clean, well-scoped documentation and configuration cleanup. All updated references are verified correct against the actual pipeline files. No remaining stale ubuntu-18.04 references exist in the repo after this change.

Detailed Findings

✅ Docker image tag — Verified correct

The FreeBSD cross-build image in cross-building.md was updated from ubuntu-18.04-cross-freebsd-12 to azurelinux-3.0-net11.0-cross-freebsd-14-amd64. This matches exactly what's used in the actual pipeline file at eng/pipelines/common/templates/pipeline-with-resources.yml:122.

✅ Webassembly instructions — Properly modernized

The "Updating Emscripten version" section removes stale Ubuntu 18.04 Dockerfile paths, outdated example JSON/YAML blocks, and dead blob/master links. The updated content:

Points to the current blob/main branch (not master)
References the 24.04 Dockerfile (current, per review feedback in second commit)
Points to helix-platforms.yml and helix-queues-setup.yml (both verified to exist) instead of the old platform-matrix.yml reference
Removes verbose example blocks that were both outdated and unnecessarily prescriptive

The rewrite is more concise and less likely to go stale since it avoids embedding specific image tags or JSON payloads.

✅ docker-compose `version` removal — Safe to remove

The version attribute was removed from three docker-compose files. Two of them had a comment: "Although the version attribute is obsolete and should be ignored, it's seemingly not the case on Build.Ubuntu.2204.Amd64.Open". I verified that Build.Ubuntu.2204.Amd64.Open is no longer referenced as a build pool in any pipeline YAML file. The stress test pipelines use $(DncEngPublicBuildPool) which resolves to NetCore-Public/NetCore-Svc-Public. The version key is officially obsolete in Docker Compose V2 and only produces warnings, so removal is correct.

✅ No remaining stale references

Grep confirms zero remaining ubuntu-18.04 references across all .md, .yml, and .yaml files in the repo. No remaining blob/master references in the changed doc files. No trailing whitespace in the changed markdown files.

Note

This review was generated by Copilot.

Generated by Code Review for issue #126127 · ◷

Copilot AI review requested due to automatic review settings March 25, 2026 21:10

github-actions bot added the area-System.Net label Mar 25, 2026

dotnet-policy-service bot assigned richlander Mar 25, 2026

Copilot started reviewing on behalf of richlander March 25, 2026 21:11 View session

richlander force-pushed the copilot/cleanup-stale-ubuntu-refs branch from 0b7b549 to f816ca5 Compare March 25, 2026 21:13

Copilot AI reviewed Mar 25, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

This was referenced Mar 26, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up stale Ubuntu references in comments and docs#126127

Clean up stale Ubuntu references in comments and docs#126127
richlander wants to merge 2 commits intomainfrom
copilot/cleanup-stale-ubuntu-refs

richlander commented Mar 25, 2026

Uh oh!

dotnet-policy-service bot commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,4 +1,3 @@
		version: '3' # Although the version attribute is obsolete and should be ignored, it's seemingly not the case on Build.Ubuntu.2204.Amd64.Open
		services:

	First update the emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/26.04/helix/webassembly/amd64/Dockerfile).
	First update the emscripten version in the [webassembly Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/24.04/helix/webassembly/amd64/Dockerfile).

Conversation

richlander commented Mar 25, 2026

Uh oh!

dotnet-policy-service bot commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 25, 2026

🤖 Copilot Code Review — PR #126127

Holistic Assessment

Detailed Findings

✅ Docker image tag — Verified correct

✅ Webassembly instructions — Properly modernized

✅ docker-compose version removal — Safe to remove

✅ No remaining stale references

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

✅ docker-compose `version` removal — Safe to remove